A "re-imagining" of the old pbench-reindex
#3614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports deleting a datasets's indexed data and triggering re-indexing. It also provides a mechanism to globally enable or disable indexing. In the short term, this provides a workaround for our sharding issues, which are preventing us from generating useful indexing anyway, by turning it off entirely for new datasets. We can also delete indexed data (and the SQL index maps) for existing datasets and, on demand, trigger re-indexing for selected datasets.
dbutenhof
added
Server
Indexing
API
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
webbnh
approved these changes
Apr 3, 2024
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good. Just two thoughts/nits which I shall pre-resolve.
dbutenhof
commented
Apr 3, 2024
Member
Author
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
Interesting. I wrote two replies to your new comments, and the Review changes button shows I have 5 pending comments, so clearly I'd written previous comments I'd neglected to submit. Being lazy right now, I'm just going to submit them rather than review whether they remain relevant or even potentially interesting. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports deleting a datasets's indexed data and triggering re-indexing. It also provides a mechanism to globally enable or disable indexing.
In the short term, this provides a workaround for our sharding issues, which are preventing us from generating useful indexing anyway, by turning it off entirely for new datasets. We can also delete indexed data (and the SQL index maps) for existing datasets and, on demand, trigger re-indexing for selected datasets.