Pbench fio cache drop #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #381 . The first commit adds a --cache-drop-script option to pbench-fio. I made a decision not to try to pass a cache dropping command in its entirety in this option because of the potential for syntax mayhem in parsing quoted strings within quoted strings, etc. Instead the user just passes the pathname of an executable script file, which is responsible for knowing which hosts to drop cache on and how to do that. ok?
The 2nd commit is an example of a cache dropping script for a Ceph (ceph-ansible-based) cluster. It uses ansible to fire cache dropping command on all OSD hosts. It is there for documentation purposes but does not have to be put in the RPM. It has been tested.