Make client list file absolute if it is not already #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed *on the controller only* for fiologparser_hist.py. Fix bug: get rid of the filename in the output of "wc -l <file>" and keep only the line count.
Unit test version of check_install_rpm modified to *not* print out the version. Gold files adjusted appropriately.
Also fix some quoting in these tests.
Fixes issue distributed-system-analysis#392. N.B. the client file is copied into the results directory under the *fixed* name fio-client.file, to facilitate indexing. Update gold file. Make bench-script/unittests table-driven, similar to the other unittests scripts. Also allow for selective unit test execution.
fiologparser_hist.py was complaining that it could not find the clat_hist files it was looking for. That's because fio --client pulls back the *_clat_hist.*.log.* files under the sampleX/ directory, not under sampleX/clients/<mumble>. Also added a couple of fixes to eliminate noise: made a stdout redirection into a stderr redirection and added a -f to rm.
Also make the unittests script table-driven.
ndokos
force-pushed
the
wip-fio-client-file
branch
from
c7c5abd to
fb87e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #392 (the second part - the first part is fixed by PR #383).
Also make the bench-scripts/unittests script table-driven, similar to the
other unittests scripts. Allow selective execution of unit tests.
This PR is rebased on top of PR#383, so it should be merged after #383.