Check for and install python-pandas #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndokos
force-pushed
the
wip-pandas
branch
3 times, most recently
from
dfc4007 to
8ea80d5
Compare
Member
Author
|
@portante: please review and merge if OK - thanks! |
Needed *on the controller only* for fiologparser_hist.py. Fix bug: get rid of the filename in the output of "wc -l <file>" and keep only the line count.
Unit test version of check_install_rpm modified to *not* print out the version. Gold files adjusted appropriately.
portante
reviewed
Sep 21, 2016
| fio_install | ||
|
|
||
| # pandas installed only on controller | ||
| if [ "$remote_only" = "n" ] ;then |
Member
There was a problem hiding this comment.
Is this supposed to only have one "=" for the comparison?
Member
Author
There was a problem hiding this comment.
Both = and == work the same way, at least when comparing strings in [ ... ] constructs. I use = mostly but as you noticed, I'm not consistent :-) I'll change the == to = throughout.
Also fix some quoting in these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed on the controller only for fiologparser_hist.py.
Issue #382