Record iterations #491
Merged
Record iterations #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$date is set by the base script which is sourced by every benchmark script, tool script and util script. It is used by benchmark scripts to create the results directory for the run, but because it is recalculated every time the base script is sourced, other components were getting a different value and e.g. could not find the results directory for the run. We now check whether $date has a value already and if so, we just leave it alone. It is only set the first time that the base script is sourced.
When a benchmark script starts a new iteration, it records it in a temporary file. This file will be used to add an iterations entry into the metadata log, to speed up processing on the server (in particular, indexing into ES).
The benchmark scripts record their iterations in a temp file. pbench-metadata-log uses that to add an iterations entry to the metadata log. pbench-add-metalog-option is a generic script that is used for that purpose, but it can add an arbitrary option to an arbitrary section of the metadata log. Modify unit tests and add a new one to test this functionality.
portante
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bench scripts record their iterations in a temp file, which is then used by pbench-metadata-log to add a [pbench] iterations field. If that is not done, then we have to trawl through the tarball and guess the iteration names, when it is time to index. Since the benchmark scripts know their iterations, it make sense to have them save that information for later use.