Add view property for handling pagination#259
Merged
PonteIneptique merged 3 commits intodistributed-text-services:masterfrom Aug 8, 2024
Merged
Add view property for handling pagination#259PonteIneptique merged 3 commits intodistributed-text-services:masterfrom
PonteIneptique merged 3 commits intodistributed-text-services:masterfrom
Conversation
…Adds the required `view` property for paginated responses and introducing the `PartialCollectionView` and `PartialNavigationView` objects to describe the pagination.
Member
|
@monotasker Is there any reason to duplicate the type of views ? They have the same props :) |
Collaborator
Author
|
I don't really see one, no. We had a type in our example that was named specifically for collections, and I just didn't think about changing the type name to make it more generic :D Shall I amalgamate the two types with something like |
Member
|
PaginationObject would be clear enough no ? |
Collaborator
Author
|
Yep. And maybe a bit clearer.Sent from my iPhoneOn Aug 7, 2024, at 5:36 PM, Thibault Clérice ***@***.***> wrote:
PaginationObject would be clear enough no ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Actually, just Pagination, because we did not call thing resourceobject
…On Wed, 7 Aug 2024, 6:23 pm Ian W. Scott, ***@***.***> wrote:
Yep. And maybe a bit clearer.Sent from my iPhoneOn Aug 7, 2024, at
5:36 PM, Thibault Clérice ***@***.***> wrote:
PaginationObject would be clear enough no ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOXEZWT77EAOOOMLVJSUALZQKM4TAVCNFSM6AAAAABMCWKGOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZUGQ2DSMZWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Collaborator
Author
|
Done. The two new types have been amalgamated as one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
viewproperty to returned Navigation and Collection/Resource objects if the response is paginated. AddedPartialCollectionViewandPartialNavigationViewobject types for the values of theviewproperty.NB: This PR is cumulative depending on the previous PR harmonizing the Resource object properties.