Skip to content

Fix default_credentials in azure storage provider#4619

Merged
milosgajdos merged 1 commit intodistribution:mainfrom
switchboardOp:main
Apr 9, 2025
Merged

Fix default_credentials in azure storage provider#4619
milosgajdos merged 1 commit intodistribution:mainfrom
switchboardOp:main

Conversation

@switchboardOp
Copy link
Copy Markdown
Contributor

@switchboardOp switchboardOp commented Apr 7, 2025

newClient can now return a client using default azure credentials.
updated docs to include information on Azure Workload Identity.

Fixes #4618

@switchboardOp switchboardOp changed the title Fix newClient in azure storage provider Fix default_credentials in azure storage provider Apr 7, 2025
@milosgajdos
Copy link
Copy Markdown
Member

Can you squash @switchboardOp looks like GHA is stuck

it can now return a client using default azure credentials
updated docs to include information on Azure Workload Identity

Signed-off-by: Lucas Melchior <lucasmelchior@flywheel.io>

fix anchor link in docs

Signed-off-by: Lucas Melchior <lucasmelchior@flywheel.io>
@switchboardOp
Copy link
Copy Markdown
Contributor Author

CI still looks hung up @milosgajdos maybe waiting on approval? 🤷
anything else I can do?

@milosgajdos
Copy link
Copy Markdown
Member

Let me try closing and reopening

@milosgajdos milosgajdos closed this Apr 8, 2025
@milosgajdos milosgajdos reopened this Apr 8, 2025
Copy link
Copy Markdown
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@milosgajdos milosgajdos merged commit e028a30 into distribution:main Apr 9, 2025
22 checks passed
@switchboardOp
Copy link
Copy Markdown
Contributor Author

Thanks for getting it in so fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure storage driver default_credentials don't work with Workload Identity

3 participants