feat: extract redis config to separate struct#4620
Merged
milosgajdos merged 1 commit intodistribution:mainfrom Apr 29, 2025
Merged
feat: extract redis config to separate struct#4620milosgajdos merged 1 commit intodistribution:mainfrom
milosgajdos merged 1 commit intodistribution:mainfrom
Conversation
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
milosgajdos
approved these changes
Apr 21, 2025
Member
milosgajdos
left a comment
milosgajdos
left a comment
There was a problem hiding this comment.
This will make it a bit harder to keep up with Redis module, but maybe that's ok for stability sake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a dedicated RedisOptions struct to encapsulate Redis client configuration in a clean, reusable, and extensible way. This change promotes better separation of concerns, easier testing, and improved readability of configuration-related code.