s3-aws: fix build for 386#4642
Merged
wy65701436 merged 1 commit intodistribution:mainfrom Aug 11, 2025
Merged
Conversation
When building for 386, we got the following build error: registry/storage/driver/s3-aws/s3.go:312:99: cannot use maxChunkSize (untyped int constant 5368709120) as int value in argument to getParameterAsInteger (overflows) This is because the s3_64bit.go is used. Adjust the build tag matching in s3_32bit.go and s3_64bit.go to fix this issue. Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
milosgajdos
approved these changes
May 29, 2025
Member
|
PTAL @thaJeztah |
milosgajdos
requested review from
Jamstah,
joaodrp and
wy65701436
and removed request for
joaodrp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building for 386, we got the following build error:
registry/storage/driver/s3-aws/s3.go:312:99: cannot use
maxChunkSize (untyped int constant 5368709120) as int value
in argument to getParameterAsInteger (overflows)
This is because the s3_64bit.go is used. Adjust the build tag matching in s3_32bit.go and s3_64bit.go to fix this issue.