Skip to content

docs: Add note about OTEL_TRACES_EXPORTER#4669

Merged
milosgajdos merged 1 commit intodistribution:mainfrom
jcpunk:otel-trace-disable
Jul 9, 2025
Merged

docs: Add note about OTEL_TRACES_EXPORTER#4669
milosgajdos merged 1 commit intodistribution:mainfrom
jcpunk:otel-trace-disable

Conversation

@jcpunk
Copy link
Copy Markdown
Contributor

@jcpunk jcpunk commented Jul 8, 2025

This tweak doesn't yet appear in the official documentation, but is in #4270

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this LGTM

I left a comment on the related ticket, because I'm wondering if we should set this as default for the image (not the binary itself, as that may be running in other kind of environments); #4270 (comment)

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@jcpunk jcpunk requested a review from thaJeztah July 9, 2025 15:42
Copy link
Copy Markdown
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, PTAL again @thaJeztah

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@milosgajdos milosgajdos merged commit 17dc6f9 into distribution:main Jul 9, 2025
21 checks passed
@jcpunk jcpunk deleted the otel-trace-disable branch July 9, 2025 18:41
@jcpunk
Copy link
Copy Markdown
Contributor Author

jcpunk commented Jul 9, 2025

Thanks! Does the doc get auto built and published or will we need to wait for a release?

@milosgajdos
Copy link
Copy Markdown
Member

Thanks! Does the doc get auto built and published or will we need to wait for a release?

It should get auto built and published to GH pages, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants