client: add Accept headers to Exists() HEAD#4715
Merged
joaodrp merged 1 commit intodistribution:mainfrom Oct 16, 2025
Merged
Conversation
The manifest Exists() client call issued a HEAD without any Accept headers. Some OCI-focused registries require an explicit Accept for manifest content negotiation, causing HEAD to fail (404/406) even when the manifest exists. The Get() path already sets Accept; Exists() did not. This change adds all supported manifest media types from distribution.ManifestMediaTypes() as Accept headers to the Exists() HEAD request, aligning behavior with Get() and improving OCI interoperability. Tests: - Regression: Exists() returns true when Accept is present and false when stripped (negative path), mirroring real-world behavior. Risk/compatibility: - Low. Registries that ignore Accept on HEAD continue to work. - Redirect handling is unchanged; existing CheckRedirect preserves Accept. Signed-off-by: Artem Tkachuk <artemtkachuk@yahoo.com>
Contributor
Author
|
@milosgajdos Hello! Looks like I can't tag you as a reviewer. Would appreciate it if you could take a look at this when you get a chance. Thanks! |
milosgajdos
approved these changes
Oct 16, 2025
joaodrp
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: add Accept headers to Exists() HEAD
Adds Accept headers (from
distribution.ManifestMediaTypes()) to theHEADrequest in(*manifests).Exists, aligning it withGet()andfixing failures on registries that require explicit OCI media types.
Real-world example:
Without Accept, some registries return 404/406 even when the manifest
exists.
Tests:
stripped (negative path).
Risk/compatibility:
CheckRedirectpreserves Accept.