refactor: remove redundant variable declarations in for loops#4741
Merged
milosgajdos merged 1 commit intodistribution:mainfrom Nov 19, 2025
Merged
refactor: remove redundant variable declarations in for loops#4741milosgajdos merged 1 commit intodistribution:mainfrom
milosgajdos merged 1 commit intodistribution:mainfrom
Conversation
Signed-off-by: efcking <efcking@outlook.com>
thaJeztah
approved these changes
Nov 19, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I think there's a linter for this as well that we could enable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of Go has been optimized, and variables do not need to be reassigned.
For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore