Expose useFIPSEndpoint for S3#4764
Merged
milosgajdos merged 1 commit intodistribution:mainfrom Jan 8, 2026
Merged
Conversation
1raghavmahajan
force-pushed
the
rm/add-fips-support
branch
2 times, most recently
from
6064f68 to
acb09f2
Compare
Signed-off-by: Raghav Mahajan <rmahajan@palantir.com>
1raghavmahajan
force-pushed
the
rm/add-fips-support
branch
from
acb09f2 to
33dab39
Compare
Contributor
Author
|
Thanks for the quick review. I've rebased on the latest main (with changes from #4763). |
thaJeztah
approved these changes
Jan 8, 2026
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
TIL (or, well, Yesterday), thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
useDualstackEndpoint. This would tell the S3 client to use the FIPS-compliant endpoints.Includes changes from #4763Merged