fix: set MD5 on GCS writer before first Write call in putContent#4803
Merged
milosgajdos merged 2 commits intodistribution:mainfrom Mar 17, 2026
Merged
Conversation
Signed-off-by: Joonas Bergius <joonas@defenseunicorns.com>
joonas
force-pushed
the
fix/gcs-putcontent-md5-before-write
branch
from
9079c0f to
2957c89
Compare
milosgajdos
approved these changes
Mar 6, 2026
Member
|
PTAL @thaJeztah |
squizzi
approved these changes
Mar 17, 2026
Co-authored-by: Kyle Squizzato <kyle@replicated.com> Signed-off-by: Joonas Bergius <joonas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the comment on
storage.Writer:Therefore, MD5 has to be set before the first to call to Write.