Admin, UI: Improve accessibility and testability#160
Merged
Conversation
ptoussai
force-pushed
the
fix/admin-label-accessibility
branch
3 times, most recently
from
1222ac9 to
4531208
Compare
ptoussai
force-pushed
the
fix/admin-label-accessibility
branch
from
7c12623 to
2719253
Compare
Add ARIA attributes, semantic roles, and proper label linkage across 22 components to enable reliable semantic locators and improve screen reader support.
ptoussai
changed the title
ptoussai
force-pushed
the
fix/admin-label-accessibility
branch
from
2719253 to
6c55302
Compare
lehni
reviewed
Apr 9, 2026
Contributor
lehni
left a comment
lehni
left a comment
There was a problem hiding this comment.
Written by Claude
Solid accessibility pass — ARIA roles and states are used correctly throughout. Two minor observations below, neither blocking.
lehni
reviewed
Apr 9, 2026
| .dito-list( | ||
| v-if="isReady" | ||
| :id="dataPath" | ||
| role="region" |
Contributor
There was a problem hiding this comment.
aria-label is set here and again on the inner table with the same value — screen readers may announce it twice. Consider only labeling the table or using aria-labelledby to share a single label element.
lehni
reviewed
Apr 9, 2026
| .dito-tabs | ||
| .dito-tabs(role="tablist") | ||
| template( | ||
| v-for="(tabSchema, key) in tabs" |
Contributor
There was a problem hiding this comment.
The tab pattern is correct (role="tab", aria-selected, tabindex), but the corresponding tab panels should ideally have role="tabpanel" with aria-labelledby pointing back to the tab. Could be a follow-up.
Contributor
|
@ptoussai I couldn't help and had to test reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ARIA attributes, semantic roles, and proper label linkage across 22 components to enable reliable semantic locators and improve screen reader support.