Block cmds till negotiation #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javacard km 41 aosp upmerge 0630
subrahmanyaman
commented
Jun 6, 2022
| public static final short KEYBLOB_CURRENT_VERSION = 1; | ||
| // KeyBlob Verion 1 constant. | ||
| public static final short KEYBLOB_VERSION_0 = 0; | ||
| // Device reboot states |
Contributor
Author
There was a problem hiding this comment.
Write comment about these states.
| byte deviceRebootStatus = repository.getBootEndedStatus(); | ||
| if (0 != (deviceRebootStatus & SET_BOOT_PARAMS_SUCCESS) && | ||
| 0 != (deviceRebootStatus & SET_BOOT_ENDED_SUCCESS) && | ||
| 0 != (deviceRebootStatus & SET_SYSTEM_PROPERTIES_SUCCESS) && |
Contributor
Author
There was a problem hiding this comment.
Compare with 0x0F
| case INS_GENERATE_KEY_CMD: | ||
| case INS_IMPORT_KEY_CMD: | ||
| case INS_IMPORT_WRAPPED_KEY_CMD: | ||
| case INS_ATTEST_KEY_CMD: |
Contributor
Author
There was a problem hiding this comment.
getHwInfo, addRngEntropy allowed.
Return UNKNOWN_ERROR from here.
subrahmanyaman
force-pushed
the
block_cmds_till_negotiation
branch
from
fa0707f to
9626d54
Compare
subrahmanyaman
force-pushed
the
block_cmds_till_negotiation
branch
from
9626d54 to
eeb2d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.