Some code optimizations, design changes addressing previous comments and new functionality. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed command related classes and combined them into KMKeymasterApplet class - removed context class as it is no longer needed. - changed the random number generation logic to use aes cbc with aes 128 bit key encryption as simulator does not support aes ecb and aes 256 bit key. - changed exception throwing to use ISOException.throwit() to use runtime environment's instance.
Implemented transient memory based code.
- Some Code optimizations. - ImportKey, GenerateKey and GetKeyCharacteristics functionality. - GetKeyCharacteristics only tested on jcardSim.
Code changes to crypto provider. New feature implemented but not tested.
Removed untested code from KeymasterApplet.
divegeek
pushed a commit
that referenced
this pull request
Feb 16, 2021
Revert "Move unsigned compare"
subrahmanyaman
referenced
this pull request
in subrahmanyaman/JavaCardKeymaster
Aug 26, 2021
Revert "Move unsigned compare"
mdwivedi
pushed a commit
that referenced
this pull request
Dec 7, 2021
Javacard km 41 aosp upmerge 0630
mdwivedi
pushed a commit
that referenced
this pull request
Apr 19, 2022
Incorporated review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.