PageUserAdmin doesn't work with custom user model

[qris]

We have a custom user model that has a full_name field instead of first_name and last_name.

When we set CMS_PERMISSION = True, the CMS breaks with this error:

File "/home/chris/dev/dfidbeamexchange/django/website/.ve/local/lib/python2.7/site-packages/django/contrib/admin/validation.py", line 251, in validate_list_display
% (cls.__name__, idx, field, cls.__name__, model._meta.object_name))

ImproperlyConfigured: PageUserAdmin.list_display[1], 'first_name' is not a callable or an attribute of 'PageUserAdmin' or found in the model 'PageUser'.

PageUserAdmin hard-codes the field list, which breaks it for us:

class PageUserAdmin(UserAdmin, GenericCmsPermissionAdmin):
    form = PageUserForm
    add_form = PageUserForm
    model = PageUser

    list_display = ('email', 'first_name', 'last_name', 'created_by')

What should we do here? Unregister PageUserAdmin and replace it with a custom one?

[mmarzantowicz]

Override get_list_display? https://docs.djangoproject.com/en/1.6/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_list_display

[qris]

Unfortunately that's not enough. It crashes during validating the models, which happens on import of cms.admin.useradmin (during autodiscover), not when the page is accessed. So we can't subclass the PageUserAdmin because we can't import it, or allow it to be imported.

[mmarzantowicz]

So, maybe this one https://docs.djangoproject.com/en/1.6/topics/auth/customizing/#django.contrib.auth.models.CustomUser.REQUIRED_FIELDS together with my first advice.

[qris]

@mmarzantowicz so is your advice that we should submit a pull request to Django-CMS to change the list_display to include the REQUIRED_FIELDS instead of hard-coding the list of fields? Or did I misunderstand?

[mmarzantowicz]

This might be the best you can do. Quick fix might be not to use first_name and last_name but full_name instead. Can you play with it and see if it works before making PR? I do not currently have any installation with custom User model to play with.

[qris]

OK, here's a pull request. I wasn't able yet to make a single test use a custom user model. The only way I could trigger a failure was to run the tests like this:

AUTH_USER_MODEL=customuserapp.User bin/python django-cms/develop.py test cms.AdminTestCase

I added such a test to the Travis configuration in 2eb9e84.

There are still problems with PageUserAdmin if your user model lacks some fields. Users will have to subclass it and change the fieldsets to include the fields that actually work, but at least they can import it now, so they can actually subclass it.

[digi604]

mmmh strange test failures....

[qris]

Test failures only on the custom user model build? I get test failures on trunk when I run tests locally even without my changes. Have you thought about using tox?

[digi604]

no all tests fail.... locally we run it with python develop.py test

[digi604]

yes we had a look at many different testing architectures over the year... PR with working implementation always welcome :)

[digi604]

they fail on travis: https://travis-ci.org/divio/django-cms/builds/32526618

[yakky]

@qris: I'd like to merge this in 3.0.6 but current PR has too many extraneous commits.
Would you be able to create a clean PR against current develop?

[qris]

@yakky done