Skip to content

Conversation

yakky
Copy link
Member

@yakky yakky commented Oct 4, 2014

Fix hide untranslated in menu
Fix #3472

@coveralls
Copy link

coveralls commented Oct 4, 2014

Coverage Status

Coverage decreased (-0.1%) to 87.161% when pulling ad0e9e3 on yakky:feature/fix_menu_hide_untranslated into 4fa3ff3 on divio:develop.

@yakky
Copy link
Member Author

yakky commented Oct 4, 2014

@digi604 @mkoistinen please check this change.
Tests runs and lives tests are ok, but it's the kind of small change that can have unintended consequences

@mkoistinen
Copy link
Contributor

The change and the test look good to me.

It pretty hard to test for "unintended consequences" though, ideally, our
collection of tests should have already done this. I'll install this
version into my latest projects and keep an eye on things.

@yakky
Copy link
Member Author

yakky commented Oct 4, 2014

Strangely enough there was no test coverage for this case.
I coded the obvious one, but probably more eyeballs will come up with better tests for this

digi604 added a commit that referenced this pull request Oct 6, 2014
@digi604 digi604 merged commit 2f8f7e7 into django-cms:develop Oct 6, 2014
@digi604
Copy link
Contributor

digi604 commented Oct 6, 2014

lgtm

@digi604
Copy link
Contributor

digi604 commented Oct 6, 2014

probably a leftover from the language independent publishing

@yakky yakky deleted the feature/fix_menu_hide_untranslated branch November 8, 2014 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMSMenu uses "page_queryset.published(lang)" which hides untranslated page always

4 participants