[Android] Add asin() trigonometric function#95
Conversation
|
Rebase, please. And take a look at this test: https://github.com/divkit/divkit/blob/main/test_data/expression_test_data/functions_trigonometry.json#L251 Sorry for such a late feedback. |
|
@lunarstill |
|
Seems the rebase gone wrong, there are unrelated commits. |
|
But branch has no conflicts with the base branch. May be I rebase to release branch. How to delete unrelated commits? |
Hello! You should fetch original repository and rebase your You also have to adopt contributor agreement in order to provide contributions. Please, check this instructions: https://github.com/divkit/divkit/blob/main/CONTRIBUTING.md. |
|
I rebase from main and fix merge conflict. Please check. |
| ] | ||
| }, | ||
| { | ||
| "expression": "@{asin(-1.0)}", |
There was a problem hiding this comment.
There are other tests for asin below. This case seems to be unnecessary because case with parameter -0.5 already exists.
You should add android to platforms in those cases.
There was a problem hiding this comment.
Delete this test asin(-1.0) and add "android" to test asin(-0.5)
| "value": 0.0 | ||
| }, | ||
| "platforms": [ | ||
| "android" |
|
@mobile-sergey Hi! Please fix issues so we can merge the pull-request. |
…pstream # Conflicts: # test_data/expression_test_data/function_signatures_trigonometry.json # test_data/expression_test_data/functions_trigonometry.json
|
Sorry with some troubles. I think that I fix all issues and fix merge-conflicts. |
4 participants
Issue: #79