feat: pops can be extended through their functor #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes pops work similarly to jsonnet objects. Extending a pop is much easier. You just call the pop with the attribute set to extend it with.
The
__functorI added has some magic, where it can detect if you just pass it an attrset, a function with one argument, or two arguments and pass arguments appropriately. I think this makes the process of updating pops more elegant. Without it though, I think we could just force the argument passed to the functor be an Extension.