draft-ietf-ppm-dap-18 HTTP media types#4424
Merged
tgeoghegan merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
Replace all the media types with the new singular `application/ppm-dap` media type, using a distinct `message` parameter for each message. A couple things to call out here: - There's no such thing as `application/ppm-dap;message=upload-resp`. That should be `upload-errors`, but I don't want to rename `struct UploadErrors` or implement its new behavior in this PR. - Bumps MSRV to Rust 1.87 so we can use `str::from_utf8`, stablized in that version. Part of #4402
jcjones
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all the media types with the new singular
application/ppm-dapmedia type, using a distinctmessageparameter for each message. A couple things to call out here:application/ppm-dap;message=upload-resp. That should beupload-errors, but I don't want to renamestruct UploadErrorsor implement its new behavior in this PR.str::from_utf8, stablized in that version.Part of #4402