Rename UploadResponse -> UploadErrors#4491
Merged
tgeoghegan merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
Also, send an empty response body from `POST /tasks/{task-id}/upload`
handler when there are no errors to report, per draft-ietf-ppm-dap-17.
Happily, `janus_client` already handles empty response bodies and 200 OK
correctly.
As I suspected, this was much easier to do oncethe endpoint was migrated
to Axum. Thanks, @jcjones.
Part of #4402
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
jcjones
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, send an empty response body from
POST /tasks/{task-id}/uploadhandler when there are no errors to report, per draft-ietf-ppm-dap-17.Happily,
janus_clientalready handles empty response bodies and 200 OK correctly.As I suspected, this was much easier to do oncethe endpoint was migrated to Axum. Thanks, @jcjones.
Part of #4402