Dev by DinuriJayaweera · Pull Request #58 · dizzpy/AstroLift

DinuriJayaweera · 2026-01-23T05:08:14Z

No description provided.

vercel · 2026-01-23T05:08:18Z

@Methexx is attempting to deploy a commit to the dizzpy's projects team on Vercel, but is not a member of this team. To resolve this issue, you can:

Make your repository public. Collaboration is free for open source and public repositories.
Upgrade to pro and add @Methexx as a member. A Pro subscription is required to access Vercel's collaborative features.
- If you're the owner of the team, click here to upgrade and add @Methexx as a member.
- If you're the user who initiated this build request, click here to request access.
- If you're already a member of the dizzpy's projects team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

Copilot

Pull request overview

This PR implements new overview/dashboard pages for admin, trainer, and user roles, along with improvements to attendance tracking functionality and package dependency management.

Changes:

Added comprehensive dashboard pages for admin, trainer, and user roles with real-time stats and auto-refresh functionality
Implemented attendance status tracking and history display for users
Updated API client to suppress 404 error logging for expected cases
Configured Next.js to allow i.pravatar.cc for placeholder avatars
Removed peer dependency flags and cleaned up unused QR code dependencies

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
frontend/package-lock.json	Removed "peer": true flags from multiple dependencies
backend/package-lock.json	Removed QR code related packages (qrcode, dijkstrajs, pngjs) and peer flags
frontend/next.config.ts	Added i.pravatar.cc hostname to allowed image domains for placeholder avatars
frontend/lib/api/client.ts	Suppressed console logging for 404 errors as they're expected in some cases
frontend/lib/api/attendance.ts	Added getCurrentStatus function and updated getAttendanceStats to handle inconsistent backend response format
frontend/app/trainer/overview/page.tsx	Complete rewrite adding dashboard with stats, pending requests, members list, and live activity
frontend/app/admin/overview/page.tsx	Complete rewrite adding dashboard with stats, recent payments display, and auto-refresh
frontend/app/(user)/overview/page.tsx	Complete rewrite adding user dashboard with membership, attendance, trainer info, and workout plans
frontend/app/(user)/attendance/page.tsx	Replaced mock data with real API calls to fetch attendance history

Files not reviewed (2)

backend/package-lock.json: Language not supported
frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T05:14:45Z

+  useEffect(() => {
+    const interval = setInterval(() => {
+      handleRefresh();
+    }, 30000);
+
+    return () => clearInterval(interval);
+  }, []);


The useEffect hook has an empty dependency array but calls handleRefresh, which depends on fetchDashboardData and setters. This will cause the interval to always call the same initial reference of handleRefresh. Since handleRefresh and fetchDashboardData don't have stable references, this could lead to stale closures. Consider using useCallback to memoize handleRefresh and fetchDashboardData, or include them in the dependency array (though the latter may cause the interval to be recreated on every render).

Copilot · 2026-01-23T05:14:45Z

+  // The backend returns overview at root level, not inside data
+  // So we check both response.data?.overview and (response as any).overview
+  const rawResponse = response as unknown as { success: boolean; overview?: AttendanceOverviewResponse['overview'] };
+  const overview = response.data?.overview || rawResponse.overview;


Using type assertion with 'as any' or 'as unknown' is a code smell that indicates the API response type may not match the expected type. The workaround to check both response.data?.overview and rawResponse.overview suggests an inconsistency in the backend API response format. Consider either: (1) updating the backend to return a consistent format, or (2) properly typing the response to reflect the actual backend structure instead of using type assertions.

Copilot · 2026-01-23T05:14:46Z

+          requestId: req.id,
+          memberName: req.memberId?.fullName || 'Unknown Member',
+          memberAvatar: `https://i.pravatar.cc/150?u=${req.memberId?.id}`,
+          membershipPlan: 'Membership Plan',


The membershipPlan field is hardcoded to 'Membership Plan' instead of using actual membership plan data from the request. This will display the same generic label for all requests regardless of their actual membership plan. Consider either: (1) adding the actual membership plan data to the TrainerRequest type and using it here, or (2) fetching the membership plan information from the backend.

Suggested change

membershipPlan: 'Membership Plan',

membershipPlan: (req as any).membershipPlan || 'Membership Plan',

Copilot · 2026-01-23T05:14:46Z

+        const payments = (paymentsRes.data as unknown as Array<{
+          _id: string;
+          memberName?: string;
+          memberEmail?: string;
+          amount: number;
+          currency?: string;
+          createdAt: string;
+          status?: string;
+        }>).slice(0, 5).map(payment => ({


Using type assertion with 'as unknown as Array' is a code smell that indicates the API response type doesn't match the expected type. The PaymentRecord[] type parameter for apiClient doesn't match the actual structure being cast to. Consider properly typing the API response by creating an interface for the backend payment response structure and using that as the type parameter instead of casting.

Copilot · 2026-01-23T05:14:46Z

+    const totalExercises = workoutPlans[0]?.workoutDays?.reduce((acc: number, day: { exercises?: unknown[] }) => 
+      acc + (day.exercises?.length || 0), 0
+    ) || 0;


The totalExercises calculation always uses the first workout plan (workoutPlans[0]) regardless of which workout session is being displayed in the history. This means all history entries will show the same exercise count from the first plan, which is incorrect. Each attendance record should be associated with its specific workout plan, or this field should be removed if the association isn't available.

Copilot · 2026-01-23T05:14:49Z

+      // Update stats
+      const newStats: DashboardStats = {
+        totalMembers: usersRes?.data?.pagination?.total || 0,
+        totalTrainers: trainersRes?.data?.pagination?.total || 0,
+        activeMemberships: usersRes?.data?.pagination?.total || 0, // Using members as proxy for active memberships


The activeMemberships stat is set to the same value as totalMembers, which assumes all members have active memberships. This is likely inaccurate as some members may have expired or inactive memberships. Consider fetching the actual count of active memberships from the backend or using a dedicated endpoint that returns only active memberships.

Suggested change

// Update stats

const newStats: DashboardStats = {

totalMembers: usersRes?.data?.pagination?.total || 0,

totalTrainers: trainersRes?.data?.pagination?.total || 0,

activeMemberships: usersRes?.data?.pagination?.total || 0, // Using members as proxy for active memberships

// Derive active memberships from payments data if available

const activeMembershipsCount =

paymentsRes?.success && Array.isArray(paymentsRes.data)

? (paymentsRes.data as Array<{ status?: string }>).filter(

(payment) => payment.status === 'active'

).length

: 0;

// Update stats

const newStats: DashboardStats = {

totalMembers: usersRes?.data?.pagination?.total || 0,

totalTrainers: trainersRes?.data?.pagination?.total || 0,

activeMemberships: activeMembershipsCount,

Copilot · 2026-01-23T05:14:49Z

-        "node": ">=6"
-      }
-    },
    "node_modules/qs": {


The backend code imports the 'qrcode' package, but this package has been removed from package-lock.json (along with its dependencies dijkstrajs and pngjs). This will cause a runtime error when the qrCodeService is used. Either: (1) the qrcode package should be added back to package.json and package-lock.json, or (2) if this functionality is no longer needed, the qrCodeService.js file should be removed or the import should be removed.

Copilot · 2026-01-23T05:14:49Z

+          <button className="text-sm text-gray-600 hover:text-gray-900">
+            View All Members
+          </button>


The "View All Members" button doesn't have any onClick handler or navigation functionality. This is a non-functional button that appears clickable but does nothing. Either implement the navigation/functionality for this button or remove it until the feature is ready.

Suggested change

<button className="text-sm text-gray-600 hover:text-gray-900">

View All Members

</button>

Copilot · 2026-01-23T05:14:49Z

+                  <button className="flex items-center gap-2 px-4 py-2 bg-red-600 text-white text-sm font-medium rounded-lg hover:bg-red-700">
+                    Start Now
+                    <ArrowRight size={16} />
+                  </button>


The "Start Now" button doesn't have any onClick handler or navigation functionality. This is a non-functional button that appears clickable but does nothing. Either implement the navigation/functionality for this button to actually start the workout program or remove it until the feature is ready.

Suggested change

<button className="flex items-center gap-2 px-4 py-2 bg-red-600 text-white text-sm font-medium rounded-lg hover:bg-red-700">

Start Now

<ArrowRight size={16} />

</button>

Copilot · 2026-01-23T05:14:50Z

 export default function OverviewPage() {
-  const { user, loading } = useProtectedRoute({ allowedRoles: ['user'] });
+  const [loading, setLoading] = useState(true);
+  const [profile, setProfile] = useState<UserProfile | null>(null);


Unused variable profile.

Suggested change

const [profile, setProfile] = useState<UserProfile | null>(null);

const [_profile, setProfile] = useState<UserProfile | null>(null);

Methexx and others added 6 commits January 23, 2026 08:23

fix: curent user attendece data fetching

5d76c63

Merge branch 'dev' of https://github.com/dizzpy/AstroLift into dev

8009950

fix: curent user attendece data fetching

0cbd057

feat: overview pages dummy data

2244d78

fix: user overview by fetching data

b064517

fix: admin and trainer overview

3aeb372

DinuriJayaweera requested review from Methexx, Copilot and dizzpy January 23, 2026 05:08

DinuriJayaweera self-assigned this Jan 23, 2026

Copilot started reviewing on behalf of DinuriJayaweera January 23, 2026 05:08 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

feat: ui improvements

cbf9593

dizzpy merged commit 25a37ce into main Jan 23, 2026
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#58

Dev#58
dizzpy merged 7 commits into
mainfrom
dev

DinuriJayaweera commented Jan 23, 2026

Uh oh!

vercel Bot commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	membershipPlan: 'Membership Plan',
	membershipPlan: (req as any).membershipPlan \|\| 'Membership Plan',

	<button className="text-sm text-gray-600 hover:text-gray-900">
	View All Members
	</button>

	const [profile, setProfile] = useState<UserProfile \| null>(null);
	const [_profile, setProfile] = useState<UserProfile \| null>(null);

Conversation

DinuriJayaweera commented Jan 23, 2026

Uh oh!

vercel Bot commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants