Filter empty Django group names when mirroring groups #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @francoisfreitag, |
francoisfreitag
approved these changes
May 7, 2025
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Hi @piotr-kubiak,
Thanks for the PR, the use case is clearly explained and it comes with tests ⭐.
I missed the initial notification for that PR, I’m sorry for the delay.
Member
|
I’m working on fixing the CI, don’t worry about it. |
francoisfreitag
force-pushed
the
custom-grouptype
branch
from
8bfc1bf to
a42cff9
Compare
Member
|
I pushed a fixup for the tests, please let me know if it looks good to you? |
Contributor
Author
|
Thanks @francoisfreitag, everything LGTM! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #388.