fix: django shortcuts styling #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 3 3
=========================================
Hits 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Waiting for new release :) |
add info to changelog and reademe.md
marksweb
requested changes
Jan 6, 2023
Member
marksweb
left a comment
marksweb
left a comment
There was a problem hiding this comment.
isort isn't happy about something here, but I'm not entirely sure what.
Member
Author
|
@marksweb There was a superfluous empty line in |
Member
|
@fsbraun that explains how I looked over it 😂 |
marksweb
approved these changes
Jan 6, 2023
marksweb
requested changes
Jan 6, 2023
Member
marksweb
left a comment
marksweb
left a comment
There was a problem hiding this comment.
Just spotted syntax issues in the readme
Co-authored-by: Mark Walker <theshow@gmail.com>
Co-authored-by: Mark Walker <theshow@gmail.com>
Member
Author
|
@DmytroLitvinov Please check pypi. |
|
Thank you, guys 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the styling for django-shortcuts which were deleted with their icons. The icons are not reintroduced and django-shortcuts will use its own icons also with djangocms-admin-style.
Related resources