Skip to content

Conversation

@fp4code
Copy link
Contributor

@fp4code fp4code commented Sep 24, 2017

This is a reopening of pull request #40, simplified and more compliant with http://docs.django-cms.org/en/release-3.4.x/contributing/development-policies.html?highlight=rebase#squashing-commits

If a buggy snippet was inserted as a plugin, an erroneous tag <class 'django.template.base.TemplateSyntaxError'> was inserted in the page, instead of the html-escaped message.

@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #45 into master will increase coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   65.05%   65.24%   +0.18%     
==========================================
  Files          13       13              
  Lines         186      187       +1     
  Branches       16       16              
==========================================
+ Hits          121      122       +1     
  Misses         64       64              
  Partials        1        1
Impacted Files Coverage Δ
djangocms_snippet/templatetags/snippet_tags.py 28.07% <50%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e6d57...50cab55. Read the comment docs.

@czpython czpython merged commit bb666bc into django-cms:master Sep 26, 2017
fp4code added a commit to fp4code/djangocms-snippet that referenced this pull request Sep 26, 2017
@fp4code fp4code deleted the issue-39 branch September 26, 2017 12:42
fp4code added a commit to fp4code/djangocms-snippet that referenced this pull request Sep 26, 2017
FinalAngel pushed a commit that referenced this pull request Jun 27, 2019
* Fixed error message outputs in html page (#45)

* Added parameter DJANGOCMS_SNIPPET_CACHE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants