-
Notifications
You must be signed in to change notification settings - Fork 53
Updated readme, black python code formatting #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,8 @@ You will need the following prerequisites in order to use axe-selenium-python: | |
|
|
||
| - selenium >= 3.0.0 | ||
| - Python 2.7 or 3.6 | ||
| - `geckodriver <https://github.com/mozilla/geckodriver/releases>`_ downloaded and `added to your PATH <https://stackoverflow.com/questions/40208051/selenium-using-python-geckodriver-executable-needs-to-be-in-path#answer-40208762>`_ | ||
| - The appropriate driver for the browser you intend to use, downloaded and added to your path, e.g. geckodriver for Firefox: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice |
||
| - `geckodriver <https://github.com/mozilla/geckodriver/releases>`_ downloaded and `added to your PATH <https://stackoverflow.com/questions/40208051/selenium-using-python-geckodriver-executable-needs-to-be-in-path#answer-40208762>`_ | ||
|
|
||
| Installation | ||
| ------------ | ||
|
|
@@ -73,12 +74,11 @@ Contributing | |
|
|
||
| Fork the repository and submit PRs with bug fixes and enhancements; | ||
| contributions are very welcome. You can run the tests using | ||
| `Docker <https://www.docker.com/>`_: | ||
| `tox <https://tox.readthedocs.io/en/latest/>`_: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ docker build -t axe-selenium-python . | ||
| $ docker run -it axe-selenium-python tox | ||
| $ tox | ||
|
|
||
| Resources | ||
| --------- | ||
|
|
@@ -117,7 +117,7 @@ version 1.2.3 | |
|
|
||
| version 1.2.1 | ||
| ************** | ||
| - Updated axe.min.js to ``axe-core@2.6.1`` | ||
| - Updated axe to ``axe-core@2.6.1`` | ||
| - Modified impact_included class method to reflect changes to the aXe API: | ||
| - There are now only 3 impact levels: 'critical', 'serious', and 'minor' | ||
|
|
||
|
|
@@ -132,6 +132,7 @@ version 0.0.3 | |
| - Added run method to Axe class to simplify the usage in existing test suites | ||
| - run method includes the ability to set what impact level to test for: 'minor', 'moderate', 'severe', 'critical' | ||
|
|
||
| <<<<<<< HEAD | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here |
||
| version 0.0.276 | ||
| **************** | ||
| - Added pytest-axe usage example to README | ||
|
|
@@ -141,6 +142,9 @@ version 0.0.275 | |
| - Added usage example to README | ||
|
|
||
| version 0.0.273 | ||
| ======= | ||
| version 0.0.28 | ||
| >>>>>>> ba24ec56528e4458f0a5604a8d511923c943a479 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here |
||
| **************** | ||
| - Added selenium instance as a class attribute | ||
| - Changed file paths to OS independent structure | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,11 @@ deps = -raxe_selenium_python/tests/requirements/flake8.txt | |
| commands = flake8 {posargs:.} | ||
|
|
||
| [flake8] | ||
| ignore = E501 | ||
| max-line-length = 88 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool, this is new to me (-: |
||
| # Black will break a line before a binary operator when splitting a block | ||
| # of code over multiple lines. This is so that Black is compliant with the | ||
| # recent changes in the PEP8 style guide. | ||
| ignore = W503 | ||
|
|
||
| [isort] | ||
| default_section = THIRDPARTY | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question, not a nit. What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the install tells Travis where the dependency file is, the default is ./requirements.txt
The second line is to prevent Travis from running tests in the deploy stage (since tests have already been run)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beauty 👍