Updated readme, black python code formatting #136
Conversation
kimberlythegeek
commented
Sep 18, 2018
kimberlythegeek
commented
- removed flake8 ignore line too long
- make it black
- Updated README to remove Docker references
kimberlythegeek
force-pushed
the
update_readme
branch
from
160ed5e to
217b4cb
Compare
* update readme to remove docker reference
kimberlythegeek
force-pushed
the
update_readme
branch
from
f8bab34 to
ba24ec5
Compare
m8ttyB
left a comment
m8ttyB
left a comment
There was a problem hiding this comment.
Looks like a merge when bad, there are a few artifacts from it. Example, <<<<<<< HEAD and >>>>>>>
| - node_modules | ||
|
|
||
| install: pip install -r axe_selenium_python/tests/requirements/tests.txt | ||
| script: skip |
There was a problem hiding this comment.
A question, not a nit. What does this line do?
There was a problem hiding this comment.
the install tells Travis where the dependency file is, the default is ./requirements.txt
The second line is to prevent Travis from running tests in the deploy stage (since tests have already been run)
| - selenium >= 3.0.0 | ||
| - Python 2.7 or 3.6 | ||
| - `geckodriver <https://github.com/mozilla/geckodriver/releases>`_ downloaded and `added to your PATH <https://stackoverflow.com/questions/40208051/selenium-using-python-geckodriver-executable-needs-to-be-in-path#answer-40208762>`_ | ||
| - The appropriate driver for the browser you intend to use, downloaded and added to your path, e.g. geckodriver for Firefox: |
README.rst
Outdated
|
|
||
| version 1.2.1 | ||
| ************** | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Oops, looks like this crept into your pr
README.rst
Outdated
| - Updated axe.min.js to ``axe-core@2.6.1`` | ||
| ======= | ||
| - Updated axe to ``axe-core@2.6.1`` | ||
| >>>>>>> ba24ec56528e4458f0a5604a8d511923c943a479 |
| - Added run method to Axe class to simplify the usage in existing test suites | ||
| - run method includes the ability to set what impact level to test for: 'minor', 'moderate', 'severe', 'critical' | ||
|
|
||
| <<<<<<< HEAD |
| version 0.0.273 | ||
| ======= | ||
| version 0.0.28 | ||
| >>>>>>> ba24ec56528e4458f0a5604a8d511923c943a479 |
|
@m8ttyB yearrrrgh. Thanks. I'll clean it up |
m8ttyB
left a comment
m8ttyB
left a comment
There was a problem hiding this comment.
r+ assuming the build passes. @stephendonner has a finer eye than I for Travis build details.
|
|
||
| [flake8] | ||
| ignore = E501 | ||
| max-line-length = 88 |
|
Sorry, slow to the draw! LGTM too; r+ |
3 participants
