AttributeError: 'Response' object has no attribute 'template_name'

[someidiot]

Using django-prometheus 1.0.9 with django 1.11.2.

I have some django-rest-framework views that are being cached with the cache_page decorator like:

@method_decorator(cache_page(settings.CACHE_TIMEOUT_API))
def dispatch(self, *args, **kwargs):
    return super(BaseAPICachedView, self).dispatch(*args, **kwargs)

When there is a cache hit, the django-prometheus middleware fails in middleware.py:135 with AttributeError: 'Response' object has no attribute 'template_name'

def process_template_response(self, request, response):
    responses_by_templatename.labels(str(
        response.template_name)).inc()
    return response

Sure enough, the cached views don't seem to have template_name. I fixed it by checking for the attribute first, not sure if that's the best way but it works for me:

def process_template_response(self, request, response):
    if hasattr(response, 'template_name'):
        responses_by_templatename.labels(str(
            response.template_name)).inc()
    return response

[korfuri]

Interesting. I'm not familiar with cache_page so before I fix I should ask - do you think ignoring the request in responses_by_templatename is the best way to go here? Should we account them to something like template="<unknown_template>" instead?

[someidiot]

Yeah, that's probably better so at least the views are included in the metrics.

[elnappo]

Same error here, sadly I can't use this awesome project in my application due to this bug and #42.

Django 2.0.2
django-prometheus 1.0.11
Python 3.6.4

[adilnaimi]

same error

Django 1.11.10
django-prometheus 1.0.11
Python 3.6.4

[adilnaimi]

I submitted a PR #63 based on
#28 which is old, I only added the test to my env:

Django 1.11.10
django-prometheus 1.0.11
Python 3.6.4