Handle nested OneToOneField when related object doesn't exist #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case where a nested field is a
OneToOneFieldand the related object doesn't exist. Attempting to access the attribute throws aRelatedObjectDoesNotExistexception which causesdjango-elasticsearch-dslto not be able to index the model.Fix simply checks if the exception thrown is an
ObjectDoesNotExistexception (which is a subclass ofAttributeError) and if so returnsNonefor the instance, allowing the field to be skipped when the related object doesn't exist.Example reproduce code: