Skip to content

Fix crash with serializers that have fields which do not exist on the… #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2015
Merged

Fix crash with serializers that have fields which do not exist on the… #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36cf32b
Fix crash with serializers that have fields which do not exist on the…
Sep 22, 2015
4e95bb4
get related instance or manager before getting relation type
Sep 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rest_framework_json_api/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,12 @@ def extract_relationships(fields, resource, resource_instance):
if not isinstance(field, (RelatedField, ManyRelatedField, BaseSerializer)):
continue

try:
relation_instance_or_manager = getattr(resource_instance, field_name)
except AttributeError: # Skip fields defined on the serializer that don't correspond to a field on the model
continue

relation_type = get_related_resource_type(field)
relation_instance_or_manager = getattr(resource_instance, field_name)

if isinstance(field, HyperlinkedIdentityField):
# special case for HyperlinkedIdentityField
Expand Down