Skip to content

Support polymorphic nested serializer url fields #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2018
Merged

Support polymorphic nested serializer url fields #485

merged 2 commits into from
Sep 24, 2018

Conversation

@icereval
Copy link
Contributor

@icereval icereval commented Sep 22, 2018 •
edited
Loading

Description of the Change

Pass context from polymorphic serializer to child serializer in order to support fields requiring the request context such as url.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

sliverc
sliverc approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@sliverc sliverc merged commit ac93145 into django-json-api:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sliverc sliverc sliverc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@icereval @sliverc