Issue with latest BundleTracker JSON file format

[barbusina]

django-webpack-loader doesn't work with latest BundleTracker webpack plugin version 1.0.0-alpha.1

The reason in changed BundleTracker's JSON file format.

I have fixed it by changing loader.py line 83:

-return self.filter_chunks(chunks)
+return self.filter_chunks(list(map(assets['assets'].get, chunks)))

or we can add this construction for backward compatibility:
+if 'assets' in assets:
+ return self.filter_chunks(list(map(assets['assets'].get, chunks)))
+else:
+ return self.filter_chunks(chunks)

Old JSON file format:
{
"status": "done",
"chunks": {
"app": [
{
"name": "app-0828904584990b611fb8.js",
"publicPath": "http://localhost:3000/assets/bundles/app-0828904584990b611fb8.js",
"path": "/home/user/project-root/assets/bundles/app-0828904584990b611fb8.js"
}
]
}
}

New JSON file format:
{
"status": "done",
"chunks": {
"app": ["app-0828904584990b611fb8.js"]
},
"assets": {
"app-0828904584990b611fb8.js": {
"name": "app-0828904584990b611fb8.js",
"publicPath": "http://localhost:3000/assets/bundles/app-0828904584990b611fb8.js",
"path": "/home/user/project-root/assets/bundles/app-0828904584990b611fb8.js"
}
}
}

[michelts]

Hi @barbusina

According to @owais, the 1.0 version won't be backward compatible.

@gilmrjc sent the PR #232 with a solution.

[rykener]

Hi all, as this package is no longer being actively maintained I have created an alternative here: Django Manifest Loader. I'd love to have some pull requests and feature requests. Give it a shot and let us know how it goes.

[zodman]

webpack-manifest-plugin clean-webpack-plugin are out-update from webpack ...in django-manifest-loader ...

[blafasel42]

i have seen there was a merge lately. but no new release. Noob question: how do i require the current version now?

[fjsj]

@blafasel42 we're going to release next week. Meanwhile you can do pip install "git+https://github.com/django-webpack/django-webpack-loader.git@7802555"

[blafasel42]

tried with ***@***.***, but no luck:. Cannot resolve bundle chunk-vendors. Am Fr., 7. Mai 2021 um 17:42 Uhr schrieb Flávio Juvenal da Silva Junior < ***@***.***>:

…

@blafasel42 <https://github.com/blafasel42> we're going to release next week. Meanwhile you can do pip install "git+ ***@***.***" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#238 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYQAV6VPJ2IGJY3WCJXATTMQC57ANCNFSM4OUTEB5A> .

-- 100 DAYS GmbH http://100days.de

[rvlb]

Hi @blafasel42, could check how many render_bundle calls are being made on the template?
I think you might be calling render_bundle for "chunk" and "chunk-vendors", with the new version you just have to call for "chunk".

---

With the new JSON format from webpack-bundle-tracker@1.0.0-alpha.1, the "related" bundles/chunks have been grouped together. You had to call render_bundle explicitly for the main js file and for the vendors file on the previous format, now you just have to call render_bundle for the group name.

i.e.:
For the new webpack-stats.json version:

"chunks": {
    "app": ["app-0828904584990b611fb8.js", "app~vendors-0828904584990b611fb8.js"]
}

Call only render_bundle for "app" now.

[rvlb]

We've now released django-webpack-loader==1.0.0 on PyPI and webpack-bundle-tracker@1.0.0 on NPM, so both latest versions are compatible between them again. Closing the issue for now.