Skip to content

Webpack updated NoErrorsPlugin #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Webpack updated NoErrorsPlugin #200

wants to merge 1 commit into from

Conversation

@themeler
Copy link

@themeler themeler commented Jul 9, 2019

Since ~2017 it's named NoEmitOnErrorsPlugin

@themeler
Webpack updated NoErrorsPlugin
20f7e1f 
Since ~2017 it's named `NoEmitOnErrorsPlugin`
@fjsj fjsj assigned rvlb May 6, 2021
@fjsj fjsj requested a review from rvlb May 6, 2021 13:19
@fjsj fjsj unassigned rvlb Jul 15, 2021
@joaopslins
Copy link
Contributor

joaopslins commented Aug 16, 2021 •
edited
Loading

This setting is already false by default, from https://webpack.js.org/configuration/optimization/#optimizationemitonerrors

Also from https://medium.com/webpack/webpack-4-mode-and-optimization-5423a6bc597a

optimization.noEmitOnErrors

Enabled in production mode. Elsewise disabled.
Don’t write output assets when compilation errors.

Closing the PR.

@joaopslins joaopslins closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvlb rvlb Awaiting requested review from rvlb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@themeler @joaopslins @rvlb