-
Notifications
You must be signed in to change notification settings - Fork 342
Create util functions from templatetags code #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
owais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restated the CI build. Will approve if it passes but please take a look if it fails again.
Thanks for the PR
Rather than doing the work in the template tags, we do the work in utils functions so that the same functionality is available directly to Python application code. This can be useful for `media` properties on Django widgets (#95). The README has been updated to provide simple examples of usage.
|
The |
|
Please release a version to pypi with this. So incredibly useful!!! |
|
Hmm, tried just installing the git hash and got
|
|
I don't I'll have time to release this to pypi or fix direct git install or the next 2-3 days. PRs to fix git install welcome! I'll release a version to some time later this week. |
|
Ok, I created #97. :) |
|
@owais Hello! Looks like release on pypi still outdated. Do you have some time to fix this? Thanks. |
|
@pacahon I released a version to pypi yesterday. Could you check if it works for you now? |
|
@owais Thanks! I can install |
|
Of course, i forgot to respond. It's ok since yesterday. Thanks again. |
As briefly discussed in #95.
From the commit message:
It feels a bit weird to mostly cut & paste code between the files but it seems that that is most of what is needed. I'm not sure that the
get_as_tagsfunction is exactly necessary but it seemed like it might save someone some trouble if they wanted to achieve similar results.Very happy to change any and all of it. Especially the names of functions. Naming is hard :)
I've attempted to provide a bit of README and doc strings but they could be better I image.
I've run the tests locally and everything seems to pass. I confess I haven't looked at it closer than that though.
Thanks again,
Michael