Add new feature to PasswordResetView, PasswordResetForm and modify associated password_reset_email.html template#17508
Conversation
…sociated password_reset_email.html template Update PasswordResetView, PasswordResetForm to include new feature in password reset logic. Previously, when using the PasswordReset feature, it was not allowed to use a namespace, but now it is allowed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
Thanks for the patch, however all new features require an accepted ticket. Moreover this change is backward incompatible and I don't think we will accept it, so please first start a discussion on the Django Forum, where you'll reach a wider audience, and follow the guidelines with regards to requesting features. |
Is it correct to discuss the inconvenience regarding this issue with people on the forum, and if there is a consensus, create a ticket, and then modify the code and submit a pull request? |
Yes, you can submit PR when a ticket is accepted. |
Thanks :) |
2 participants
I'm not fluent in English, and I use a translation tool, so please forgive me for any possible mistranslations.
Update PasswordResetView, PasswordResetForm to include new feature in password reset logic. Previously, when using the PasswordReset feature, it was not allowed to use a namespace, but now it is allowed.
It works whether you use a namespace in urls.py or not