Skip to content

Conversation

@adamchainz
Copy link
Member

Trac ticket number

N/A

Branch description

Homebrew hasn’t used /usr/local for some time. I couldn’t find exactly which version changed that, but the 3.0.0 release notes (2021) mention that M1 Macs now support the location, so presumably before that.

This PR changes the recommended path to one that exists (tested on my mac) and covers the case where the install path is non-default.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

@adamchainz adamchainz requested review from nessita and sarahboyce April 4, 2024 19:54
@adamchainz
Copy link
Member Author

Hmm I can’t find clear evidence but it may be that Intel macs use /usr/local and M1 macs use /opt/homebrew. I only saw a passing reference on a stack overflow for a related spatialite install issue.

@adamzap
Copy link
Member

adamzap commented Apr 5, 2024

@adamchainz I think you're correct: https://docs.brew.sh/Installation

image

@adamchainz adamchainz force-pushed the spatialite_homebrew_docs branch from a77a64b to 956956b Compare April 5, 2024 10:00
@adamchainz
Copy link
Member Author

Ah, the install docs. I should have know. Thanks Adam!

Co-authored-by: Adam Zapletal <adamzap@gmail.com>
@nessita nessita force-pushed the spatialite_homebrew_docs branch from 956956b to e6b499a Compare April 10, 2024 20:05
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge once CI runs are completed.

@nessita nessita merged commit 8bbf73c into django:main Apr 10, 2024
@adamzap
Copy link
Member

adamzap commented Apr 11, 2024

Thanks for the co-author credit here. Very generous to mention me in the commit message!

@adamchainz adamchainz deleted the spatialite_homebrew_docs branch April 22, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants