Fixed #36767 -- Allowed max redirect URL length to be set on HttpResponseRedirect. #20273
+46
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunkasyap
force-pushed
the
ticket-36743
branch
2 times, most recently
from
3d80d51 to
090533c
Compare
Member
jacobtylerwalls
left a comment
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Thanks! This will be backported to prior versions. Can you add a release note for 5.2.9.txt? A merger can then copy this to the other versions that will be backported.
varunkasyap
force-pushed
the
ticket-36743
branch
from
090533c to
7382b08
Compare
varunkasyap
changed the title
varunkasyap
force-pushed
the
ticket-36743
branch
4 times, most recently
from
99c97df to
1b91137
Compare
nessita
force-pushed
the
ticket-36743
branch
from
1b91137 to
e619702
Compare
Member
|
Merged in #20331, thanks! |
Contributor
I only merged the first commit, the second one would need some work still. I'm reopening on that basis, I can rebased onto main to show the pending work. |
…mit overridable. This change allows overrides for the redirect URL max length used in HttpResponseRedirectBase and children via an optional max_length instance creation parameter. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
nessita
changed the title
nessita
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36767
Branch description
This PR fixes a issue where HttpResponseRedirect and HttpResponsePermanentRedirect enforced a strict 2048-character limit on URLs. The limit is now increased to 16384.
Checklist
mainbranch.