Fixed #36030 -- Avoid unnecessary CAST(... AS NUMERIC) for Value(Decimal) on SQLite. #20294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36030
Branch description
SQLite already preserves Decimal values without requiring an explicit
CAST(... AS NUMERIC). However, Django currently applies this CASTunconditionally in
SQLiteNumericMixin, even when the expression isa simple
Value(Decimal).As reported in ticket #36030, this produces redundant SQL and causes
unnecessary type coercion on SQLite.
Following the discussion on the ticket, this patch updates
SQLiteNumericMixin.as_sqlite()to skip numeric casting when theexpression is
Value(Decimal), matching SQLite's native behavior.This change:
No new tests are required (ticket metadata:
Needs tests: no).Checklist
mainbranch.