Fixed #36892 -- Handled lazy objects in serializer_factory#20613
Closed
Ahmedshammas wants to merge 4 commits intodjango:mainfrom
Closed
Fixed #36892 -- Handled lazy objects in serializer_factory#20613Ahmedshammas wants to merge 4 commits intodjango:mainfrom
Ahmedshammas wants to merge 4 commits intodjango:mainfrom
Conversation
📊 Coverage Report for Changed FilesNote: Missing lines are warnings only. Some lines may not be covered by SQLite tests as they are database-specific. For more information about code coverage on pull requests, see the contributing documentation. |
Member
|
Hi 👋 The PR contains unrelated changes, no tests, and doesn't follow the PR checklist for commit messages. Feel free to resubmit a PR when you have something closer to the target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36892
Branch description
This patch ensures that django.utils.functional.lazy objects (such as lazy tuples used for field choices) are correctly unwrapped before serialization.
Previously, these objects were being serialized as strings, causing the migration autodetector to falsely identify changes and generate redundant migrations on every run. I have updated serializer_factory to use _proxy____cast() for Promise objects and added a regression test in tests/migrations/test_serializer.py.
AI Assistance Disclosure (REQUIRED)
Checklist
mainbranch.