Fixed #36898 -- Documented SessionBase.is_empty().#20630
Merged
jacobtylerwalls merged 1 commit intodjango:mainfrom Feb 3, 2026
Merged
Fixed #36898 -- Documented SessionBase.is_empty().#20630jacobtylerwalls merged 1 commit intodjango:mainfrom
jacobtylerwalls merged 1 commit intodjango:mainfrom
Conversation
jacobtylerwalls
approved these changes
Feb 2, 2026
Member
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Thanks @jafarkhan83, but next time please be more careful about following the commit message style referenced in the PR checklist. I'll update it for you.
jacobtylerwalls
requested changes
Feb 2, 2026
3c040bc to
543943c
Compare
Member
|
@jafarkhan83 careful, there are multiple typos in your commit message, and no trailing period. |
543943c to
cdbb3c5
Compare
cdbb3c5 to
3b443b7
Compare
jacobtylerwalls
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36898
Branch description
To check whether the user has a session need to use Session.is_empty() but this method is not documented. Another way to check is request.session but that will always be populated if SessionMiddleware is enabled so it returns True on empty session too that makes it a pitfall.
AI Assistance Disclosure (REQUIRED)
Checklist
mainbranch.