Fixed #23812 - Replaced every range and xrange with django.utils.six.moves.range #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildbot, test this please |
There was a problem hiding this comment.
Please wrap line 2475 with list. See http://djangoci.com/job/django-pull-requests/1576/database=oracle11,python=python2.7/testReport/junit/queries.tests/ConditionalTests/test_ticket14244/ for the stacktrace.
|
buildbot, add to whitelist. |
There was a problem hiding this comment.
This effectively converts range to xrange on Python 2. We have run into subtle issues with this before -- see https://code.djangoproject.com/ticket/23140 for an example. Are you comfortable auditing the places where you made this change to identify possible issues? It may be better to defer these occurrences to a separate ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.