Fixed #26293 - Moved append_slash logic outside of prepend_www logic#6312
Closed
samuelmullin wants to merge 1 commit into
Closed
Fixed #26293 - Moved append_slash logic outside of prepend_www logic#6312samuelmullin wants to merge 1 commit into
samuelmullin wants to merge 1 commit into
Conversation
Member
There was a problem hiding this comment.
Since process_request() returns a response, the second part of the test isn't needed (see 434d309).
Member
|
Some edits: http://dpaste.com/2J098KX |
samuelmullin
force-pushed
the
ticket_26293
branch
from
5fece93 to
e60e390
Compare
This issue was a regression that was causing appending a slash to not return a redirect unless we also prepended a www, as the logic to append the slash was located side the prepend WWW logic. Moving logic required dynamically building the redirect_url as well as updating test_non_ascii_query_string_does_not_crash to expect a 301 from process_request instead of expecting no redirect. Also added a regression test (and renamed another test to differentiate the two) and release notes so this can be included in the 1.9.5 release.
samuelmullin
force-pushed
the
ticket_26293
branch
from
e60e390 to
c47cd8e
Compare
Author
|
I've updated the tests as you requested, changed the commit message and added release notes under 1.9.5 - let me know if anything else needs to be updated/changed! |
Author
|
Oh, I totally missed your edits. Will add those later. Thanks for your feedback! |
Member
|
merged in 9390da7, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving logic required dynamically building the redirect_url as well as updating test_non_ascii_query_string_does_not_crash to expect a 301 from process_request instead of expecting no redirect.
Also added a regression test (and renamed another test to differentiate the two).