Fixed incorrect syntax highlighting theme in explicit light mode with dark mode system preference. #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
commented
Apr 26, 2025
| // CSS from pygments github dark theme | ||
| @media (prefers-color-scheme: dark) { | ||
| :root { | ||
| :root[data-theme="auto"] { |
Member
Author
There was a problem hiding this comment.
Hmm, on second thought, it might be better to use :not([data-theme="light"]) instead:
The end result should be the same, but it's more consistent with the above existing code.
Member
Author
There was a problem hiding this comment.
I've changed it to use the above approach.
… dark mode system preference.
laymonage
force-pushed
the
fix-syntax-highlight-theme
branch
from
130d5ac to
b0726a1
Compare
bmispelon
approved these changes
Apr 28, 2025
Member
bmispelon
left a comment
bmispelon
left a comment
There was a problem hiding this comment.
Before:
After:
The bug appears to be fixed with the proposed changes, and they look reasonable. Nice work, thanks! 🎸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1966.
I haven't tried it out locally, so I hope this works ✌️