fix for #38/Version 0.8 with GeoFeatureModelSerializer duplicates properties #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to break tests into separate files
Contributor
Author
|
Any feedback, @nemesisdesign? |
Member
|
It looks good! it would have been better if the first commit focused on just the issue in subject and if you did the split of the tests (which is a very good idea) in a separate commit. Do you still have some time to do that or not? Let me know and I'll wait or merge accordingly. |
Member
There was a problem hiding this comment.
very minor indentation issue here
Contributor
Author
|
@nemesisdesign will get to this as a new sequence of commits, thanks. |
Contributor
Author
|
@nemesisdesign see #42 for a cleaner pull request. |
Member
|
are you familiar with git rebase -i (interactive)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of this pull request is the deletion of lines 107-111 from
rest_framework_gis/serializers.py.I've also moved all
test_*_filteringtests intotests/django_restframework_gis_tests/test_filters.pyas a first step in refactoring the unwieldytests/django_restframework_gis_tests/tests.py. I'm also testing against the whole GeoJSON hash intest_geojson_formatinstead of simply poking at a few items. This test would have immediately revealed the bug reported in #38.Finally, changed the POINT coordinates in
test_geojson_formatso that they can be distinguished from each other, and so that it's a little more intuitive to see which is longitude and which is latitude.