More customizable maildir shortcuts#2292
Conversation
|
Nice work.... I'll get back to this once the 1.9.x work starts. Thank you. |
| ;; menu entry | ||
| (mu4e--main-action-str | ||
| (concat "\t* [j" key "] " name) | ||
| (concat "j" key)) |
There was a problem hiding this comment.
Should wrap in mu4e--main-action-str (since at the least it'll make it look like the rest of mu4e's maildir shortcuts that are specified manually with mu4e-maildir-shortcuts)
|
There are changes needed for EDIT: |
| (concat "\t* [j" (string key) "] " name) | ||
| (concat "j" (string key)))) | ||
| ((stringp key) (concat "\t* " key " " name)) | ||
| (t (concat "\t* " name))) |
There was a problem hiding this comment.
Why so many spaces after \t*? I'm only asking as the space amount seems arbitrary, but perhaps for you it gives you the specific way you want it to look or something (for me it doesn't look as great if I were to take 2 of the spaces out).
|
Merging this, thanks! @llmII: it looks good for me, but surely we can tweak the details later. |
:nameattribute tomu4e-maildir-shortcutsto display maildirs with long paths nicely:key. Alternatively, allow:keyto be a custom string.I find a custom string useful for hinting at hydras.
This implements [Support maildir shortcuts without keys #2110], which has conflicts with the current code.
I also added support for separator lines with titles to categorizes maildirs. Something like
I didn't include it since it's quite hackish, but I'd be prepared to clean it up and submit it if interested.
Sorry for opening/closing two other pull requests. I'm not too used to the Github workflow :)