-
Notifications
You must be signed in to change notification settings - Fork 36
Add color options for Border Play and Mute #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color options for Border Play and Mute #143
Conversation
Personally i've always wanted a different color for the > play indicator to make it easier to read, in my mind it made sense to do the - mute indicator at the same time. In the default configs these are still mapped to the same color as cursor and normal. In adition someone on Discord was after the ability to change the dialog border so I added that while I was there. This commit also cleans up some whitespace in the parts of the code and docs that it touched.
|
Sorry another one that's probably best read with whitespace changes off. Although I did less of that this time. |
|
Feel free to suggest changes to .clang-format, I feel that particularly this change looks nicer with your formatting than the suggestion |
This is my preferred as well, I just fixed the stuff that really annoyed me and left stuff like that as it already was, I only automated the whitespace rather then going through with clangformat properly. I'll go through and rebase my patches tomorrow. |
299498a to
72935b0
Compare
|
Clang format is done, I also ran it on the header files that go with the .cpp files so there may be some headers with only formatting changes. |
1.5.0 Contributions: purelygrey Per-project option for soft clipping the output (#145) * Per-project option for soft clipping the output * Projects with Master Volume over 100 will be capped to 100 * Use pregain to saturate * Multiple saturation modes Remove drawing optimization that causes flashing in Song view (#147) * Removed drawing optimization that caused flashing in Song view clsource Scales * implementation by @MaksMakes * instrumentation by clsource simotek Add color options for Border Play and Mute (#143) * Adds different color for the > play and _ mute indicators Fix rg35xx mapping (#139) * rshoulder and lshoulder were the wrong way * Attempt to fix audio randomly dying (185) kompadre Enable skipping JUNK section for WAVs * Load more old sample pack CD rips! mrtnvgr Hide lgpt_ prefix for songs #165 Consistent view title separators #166 nine-h Reduce nag dialogs (#187) Allow user to save, load, save as and quit while song is playing Copy columns (#141) * Enables copying fx+params into any column in tables and phrases Pasting fx into notes column etc does nothing Nudge functionality (#130) * In Project view, select tempo and hold B+LEFT/RIGHT to nudge slower/faster * In Song view, pressing LT+LEFT/RIGHT will do the same Printable fx in InstrumentView (#155) * Uses ffmpeg to print reverb to currently selected sample * New sample with fx is created and assigned to the current instrument * Only available for platforms mentioned in README of this repo Other: Add line-by-line clang format (#144) Check uploads artifacts (#138) Globally accessible notifications (#137) Update to github actions checkout@v4.1.7 (#136) Fixes: Another fix for long sample names Sample names that start with the same characters get mixed up After reloading the project, samples starting with the same characters before being shortened would be mixed up and cause crashes Fix audio randomly dying (#194) Long sample names causing crashes in InstrumentView (#189) Fixed Garlic docker being outdated (#194) Bug in chainview: column warping (#134) Jumping below lowest row would cause infinite loop Jumping from row 0 was not possible in chainview Limit jump to maximum lowest populated row Set songview b jumping length to 16 rows in correspondence with LSDJ and M8 Scales no longer affect instrument numbers ([#172](#172)) Bug in Variable:SetString [#169](#169) Issue in deep clone (#135) Was possible to accidentally deep clone position into another position Fix build error for Raspi (#133) Restore 32bit linux config Crash when nudging below 0 BPM (shoutout @merumerutho) #127
Personally i've always wanted a different color for the > play indicator to make it easier to read, in my mind it made sense to do the - mute indicator at the same time. In the default configs these are still mapped to the same color as cursor and normal.
In adition someone on Discord was after the ability to change the dialog border so I added that while I was there.
This commit also cleans up some whitespace in the parts of the code and docs that it touched.