Add 64 bit soundfont support#211
Conversation
|
@djdiskmachine I'm not entirely sure how I should update the CHANGELOG since bacon3 has already been released. |
|
Wow exciting! |
|
The next release will be 1.6.0, if it works good I'll add it to the next candidate :) |
|
Will fix the formatting & build regression for windows |
| @@ -1,3 +1,11 @@ | |||
| 1.6.0 | |||
There was a problem hiding this comment.
Not sure how you want the RC to be named, so I'm happy to change as needed
|
|
||
| #define PROJECT_NUMBER "1" | ||
| #define PROJECT_RELEASE "5" | ||
| #define PROJECT_RELEASE "6" |
There was a problem hiding this comment.
As above, I'm happy to change to indicate it's RC
There was a problem hiding this comment.
Great, let's go for 1.6.0-bacon0 💪🥳
|
|
||
| simotek | ||
| Add color options for Border Play and Mute (#143) | ||
| Add color options for Border Play and Mute (#143) |
There was a problem hiding this comment.
Hmm, my editor's autoformatting has gone a bit aggressive, sorry about that. I can revert if you need me to.
|
Sorry about the over-enthusiastic clang-format job. As you know the formatting is really all over the place and I made the line-by-line format so that not every commit would be impossible to review. |
|
lgpt_FLAT.zip |
I did run clang-format for all of my changed lines after I noticed the instructions, then setup the hook, so not 100% sure why we're still getting a formatting issue. Will look into it when I get some time. |
|
Ok, I've run the formatter again, hopefully it should pass CI this time. |
|
Thank you very very much, It's really great to have future-proofed SoundFont support! =) |
|
No problem, glad to be of assistance! |
Description
This PR adds soundfont support to 64-bit systems, by fixing a limitation in the soundfont library.
The problem was due to the soundfont library storing addresses in a 32-bit DWORD, which causes problems in systems with 64-bit addresses.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist:
sources/Application/Model/Project.h