Skip to content

Add 64 bit soundfont support#211

Merged
djdiskmachine merged 12 commits into
djdiskmachine:masterfrom
drbscl:64-bit-soundfont
Dec 21, 2025
Merged

Add 64 bit soundfont support#211
djdiskmachine merged 12 commits into
djdiskmachine:masterfrom
drbscl:64-bit-soundfont

Conversation

@drbscl
Copy link
Copy Markdown

@drbscl drbscl commented Dec 20, 2025

Description

This PR adds soundfont support to 64-bit systems, by fixing a limitation in the soundfont library.

The problem was due to the soundfont library storing addresses in a 32-bit DWORD, which causes problems in systems with 64-bit addresses.

Note: I have only been able to test the RG35XX build, since this is the only hardware I have on hand to test with. I recommend others test this change on other hardware before promoting this to a stable release.

Type of change

How Has This Been Tested?

Test Configuration:

  • Hardware: RG34XX SP (With RG35XX build, these devices all have the same SoC)
  • Test steps: Open a project that includes a soundfont, then create & play new phrases with instruments using that soundfont.

Checklist:

  • I have performed a self-review of my code
  • I have commented particularly in hard-to-understand areas
  • I have updated CHANGELOG
  • I have updated docs/wiki/What-is-LittlePiggyTracker.md reflecting my changes
  • I have version bumped in sources/Application/Model/Project.h
  • My changes generate no new warnings (build without your change then apply your change to check this)

@drbscl
Copy link
Copy Markdown
Author

drbscl commented Dec 20, 2025

@djdiskmachine I'm not entirely sure how I should update the CHANGELOG since bacon3 has already been released.

@djdiskmachine
Copy link
Copy Markdown
Owner

Wow exciting!
I can try it out on my machine and report back :)

@djdiskmachine
Copy link
Copy Markdown
Owner

The next release will be 1.6.0, if it works good I'll add it to the next candidate :)

@drbscl
Copy link
Copy Markdown
Author

drbscl commented Dec 20, 2025

Will fix the formatting & build regression for windows

Comment thread CHANGELOG Outdated
@@ -1,3 +1,11 @@
1.6.0
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you want the RC to be named, so I'm happy to change as needed


#define PROJECT_NUMBER "1"
#define PROJECT_RELEASE "5"
#define PROJECT_RELEASE "6"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, I'm happy to change to indicate it's RC

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's go for 1.6.0-bacon0 💪🥳

@drbscl drbscl marked this pull request as ready for review December 20, 2025 17:43
Comment thread CHANGELOG

simotek
Add color options for Border Play and Mute (#143)
Add color options for Border Play and Mute (#143)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, my editor's autoformatting has gone a bit aggressive, sorry about that. I can revert if you need me to.

@djdiskmachine
Copy link
Copy Markdown
Owner

Sorry about the over-enthusiastic clang-format job. As you know the formatting is really all over the place and I made the line-by-line format so that not every commit would be impossible to review.
Did you find the commit hook I made?
I'll try to review proper this evening and give things a test run.

@djdiskmachine
Copy link
Copy Markdown
Owner

djdiskmachine commented Dec 21, 2025

lgpt_FLAT.zip
For MacOS I can attest that it does appear to work!
I can load the attached project, start playing and it plays the song fine. Great success!
I'll have another look at it on an Ubuntu machine this evening, but looks very promising.
Great work! =)

@drbscl
Copy link
Copy Markdown
Author

drbscl commented Dec 21, 2025

Sorry about the over-enthusiastic clang-format job. As you know the formatting is really all over the place and I made the line-by-line format so that not every commit would be impossible to review.

Did you find the commit hook I made?

I'll try to review proper this evening and give things a test run.

I did run clang-format for all of my changed lines after I noticed the instructions, then setup the hook, so not 100% sure why we're still getting a formatting issue.

Will look into it when I get some time.

@drbscl
Copy link
Copy Markdown
Author

drbscl commented Dec 21, 2025

Ok, I've run the formatter again, hopefully it should pass CI this time.

@djdiskmachine djdiskmachine enabled auto-merge (squash) December 21, 2025 21:53
@djdiskmachine djdiskmachine merged commit e0a4ef7 into djdiskmachine:master Dec 21, 2025
12 checks passed
@djdiskmachine
Copy link
Copy Markdown
Owner

Thank you very very much, It's really great to have future-proofed SoundFont support! =)

@drbscl
Copy link
Copy Markdown
Author

drbscl commented Dec 22, 2025

No problem, glad to be of assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Can't import a soundfont on rg35xx+

2 participants