Skip to content

Adds deep clone#81

Merged
djdiskmachine merged 5 commits intomasterfrom
deep_clone
Jun 20, 2024
Merged

Adds deep clone#81
djdiskmachine merged 5 commits intomasterfrom
deep_clone

Conversation

@djdiskmachine
Copy link
Copy Markdown
Owner

Implementation done by Koisignal! (https://github.com/koi-ikeno)

By repeating a clone operation the phrases inside the clone are cloned as well.

djdiskmachine and others added 5 commits June 11, 2024 20:18
Clones selected chain and the phrases within

TODO:
    Need to instrument
    Restore old clone
Does not behave great
Issues with copy/paste
Clone fine
deepClone fine
Remove logging
  Copy/paste works
  Clone fine
  deepClone fine
  Removed deepclone enum

TODO:
  Remove logging
@djdiskmachine
Copy link
Copy Markdown
Owner Author

Implementation done by Koisignal! (https://github.com/koi-ikeno)

By repeating a clone operation the phrases inside the clone are cloned as well.

@djdiskmachine djdiskmachine merged commit 07c03d0 into master Jun 20, 2024
@djdiskmachine djdiskmachine deleted the deep_clone branch July 1, 2024 20:05
djdiskmachine pushed a commit that referenced this pull request Sep 21, 2024
Was possible to accidentally deep clone position into
another position
Now only possible to deep clone on same position or when jumping

Relates to:
	#98
	#81
djdiskmachine added a commit that referenced this pull request Sep 24, 2024
Was possible to accidentally deep clone position into
another position
Now only possible to deep clone on same position

Relates to:
	#98
	#81

Co-authored-by: djdiskmachine <djdiskmachine@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant